It's long therefore I split it to different module that you can click instead of scroll,
If Question Code AUD-009 , get Record from User by passing varUserId to get
If other Question Code : Update Proposal Review with values that retrieved from Step 1.
I was working on requirement which involving on after trigger update and suddenly have to stop when I hit governer limit in Process Builder that not related to the current changes.
Too many SOQL queries: 101
Usually when I got this type of error I will worry and start looking into my code which is not wrong approach at all. However it is good to start with the Process Builder that hinting the exception although the changes that we are working on seem like not relevant. Actually it is relevant when it involves process builder , flow , trigger and workflow (everything that involve DML)
Let say that is current data model , please ignore the sense of object name,field name as I just renamed it from actual name. Pay attention on the relationship.
- Product Proposal is a parent object of Proposal Review. It holds Region and Country.
- Audit Question is lookup field in Proposal Review
- Process Builder is fired whenever Proposal Review is created to populate correct field for Email Note and Reviewer Email.
- However for region related question, the notification email need to be sent to Sales Ops that in charge on specific Region or even narrow down to the Country level.
The current implementation is :
Fires autolauched flow without any specific criteria and it passes several info to flow such as :
- VarReviewerId = Proposal_Review__c.Id
- VarQuestionId = Proposal_Review__c.Audit_Question__r.Id
- VarUserId = Formula field to pass specific user Id based on Region and Country
- Get Records : Retrieve Audit Question using varAuditId to get
- Email Note
- Reviewer Email
- Question Code
- Check if the Question Code is AUD-009 (Region Question)
- User Email
- Then update Proposal Review with values with
- Reviewer Email with User Email
- Email Note that retrieved from Step 1
- Reviewer Email with default email
- Email Note
As you can see many redundancy in this flow. The flow achieved the requirement however it can be done be better.
What can be improved from this current implementation
- Some of the action in the Flow can be moved to Process Builder because the logic is to update Proposal Review that initiate the Process Builder.
- Remove query in Flow to retrieve Audit Question as it can be retrieved in Process Builder.